Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadow-dom: Add testcases for attachShadow() with disabledFeatures=['shadow'] #16795

Merged
merged 4 commits into from
May 16, 2019
Merged

shadow-dom: Add testcases for attachShadow() with disabledFeatures=['shadow'] #16795

merged 4 commits into from
May 16, 2019

Conversation

tkent-google
Copy link
Contributor

Specification PR: whatwg/dom#760

This was referenced May 13, 2019
Merged
Closed
Merged
annevk
annevk approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, except we should probably wait with landing these until we settle the "which exception should we throw" question I raised in DOM.

@domenic domenic merged commit 7e939f6 into master May 16, 2019
@domenic domenic deleted the tkent-disabled-attachShadow branch May 16, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic domenic approved these changes

@hayatoito hayatoito Awaiting requested review from hayatoito

@kojiishi kojiishi Awaiting requested review from kojiishi

@rniwa rniwa Awaiting requested review from rniwa

@TakayoshiKochi TakayoshiKochi Awaiting requested review from TakayoshiKochi

Assignees

@rniwa rniwa

Labels
shadow-dom wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tkent-google @domenic @annevk @rniwa @wpt-pr-bot